Poly-commitment: more docs and comments #2642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tested the hypothesis by adding an assert that padding equals zero, and run all the tests for kimchi.
In particular, adding the hypothesis we expect on the semantics of the inhabitant of the second type parameter.
dannywillems
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2642 +/- ##
==========================================
+ Coverage 69.54% 69.55% +0.01%
==========================================
Files 243 243
Lines 57638 57653 +15
==========================================
+ Hits 40082 40101 +19
+ Misses 17556 17552 -4 ☔ View full report in Codecov by Sentry. |
marcbeunardeau88
force-pushed
the
dw-mb/more-docs-and-comments-plz
branch
from
11489e9
to
1b8e926
Compare
Base automatically changed from
dw/move-combine-evaluations-into-kzg
to
master
October 2, 2024 12:50
marcbeunardeau88
force-pushed
the
dw-mb/more-docs-and-comments-plz
branch
from
9d0c801
to
271e3af
Compare
dannywillems
commented
Oct 2, 2024
marcbeunardeau88
approved these changes
Oct 2, 2024
dannywillems
commented
Oct 2, 2024
dannywillems
commented
Oct 2, 2024
| @@ -466,6 +476,7 @@ pub fn combined_inner_product<F: PrimeField>( | |||
| } | |||
|
|
|||
| /// Contains the evaluation of a polynomial commitment at a set of points. | |||
| #[derive(Clone)] | |||
There was a problem hiding this comment.
Is it still required?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.